Remove failure crate
#564
Remove failure crate
#564
Conversation
There was a problem hiding this comment.
The changes so far LGTM.
Need to bump version number
But since this upgrade changes the function signatures, this will be a breaking change of all crates that are updated. Which means you need to increase the minor version number of all crates you updated.
Concerns about changes and crate version before this breaking change
Before we merge this PR, I have to get clear about out release strategy about crates under rust-sgx.
If we want to have a version without this change but contains all changes before this PR and after last publish.
We need to publish new version of crates with new patch version if they only contain some version compatible changes.
Otherwise, we could just bump the minor versions in this PR.
What's you idea about this ^^ |
|
@Taowyoo Please review last 2 commits |
There was a problem hiding this comment.
When using a new MINOR version, you should start with 0 for MINOR.
Note:
You could use this tool https://github.com/crate-ci/cargo-release to bump version in a more reliable way with command cargo release version minor under root of each crate.
Co-authored-by: YX Cao <[email protected]>
|
Please fix the ci, some versions in |
…to ns/fix_failure_vulnerability
|
@Taowyoo Fixed, please review |
Changes all usages of
failurecrate (https://crates.io/crates/failure) across the project intothiserror(https://crates.io/crates/thiserror) andanyhow(https://crates.io/crates/anyhow). This change fixes vulnerability introduced by thefailurecrate (https://rustsec.org/advisories/RUSTSEC-2020-0036)